Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 9, 2025

Types depends on core but we accidentally published it before core. Not the end of the world but theoretically, if publishing core failed, we would have published a faulty types package. h/t @BYK for detecting this!

Closes #18431

@Lms24 Lms24 requested review from a team, RulaKhaled and mydea and removed request for a team December 9, 2025 09:33
@Lms24 Lms24 requested review from JPeer264 and s1gr1d and removed request for RulaKhaled and mydea December 9, 2025 09:33
@Lms24 Lms24 enabled auto-merge (squash) December 9, 2025 10:59
@Lms24 Lms24 merged commit ca146a5 into develop Dec 9, 2025
38 checks passed
@Lms24 Lms24 deleted the lms/chore-publish-types-craft-order branch December 9, 2025 11:00
@BYK
Copy link
Member

BYK commented Dec 9, 2025

Why not use the workspaces feature in Craft which detected the issue? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(publish): Fix publish order for @sentry/types

4 participants